Switch on async-timeout > 4 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
approved these changes
Nov 3, 2021
| @@ -7,7 +7,9 @@ module = "aiojobs" | |||
| author = "Andrew Svetlov" | |||
| author-email = "andrew.svetlov@gmail.com" | |||
| home-page = "https://github.com/aio-libs/aiojobs" | |||
| requires=[] | |||
| requires=[ | |||
| "async-timeout >= 4" | |||
There was a problem hiding this comment.
Suggested change
| "async-timeout >= 4" | |
| "async-timeout >= 4.0.0" |
Let's keep the full version
|
The PR is good. I cannot estimate when I can find a time for this migration, and help is welcome! |
This was referenced Nov 3, 2021
|
Could you make a tag with this version, please? There's a problem using aiojobs with aiohttp because of different versions of async_timeout |
|
I'd like to merge #277 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add support new async-timeout and switch on them.
Are there changes in behavior for the user?
No
Related issue number
#247
#268
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.